Wicket
  1. Wicket
  2. WICKET-3393

Remove ApplicationContextHolder from SpringComponentInjector

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5-RC1
    • Fix Version/s: 1.5-RC2
    • Component/s: wicket-spring
    • Labels:
      None

      Description

      ApplicationContextHolder is a private inner class in o.a.w.spring.injection.annot.SpringComponentInjector class. It was designed to be used as a workaround to store the non serializable spring ApplicationContext in a serializable wrapper as Application metadata. But Application metadata does not need to be Serializable anymore so this boxing is not needed.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        4h 14m 1 Peter Ertl 26/Jan/11 22:56
        Peter Ertl made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Peter Ertl [ pete ]
        Fix Version/s 1.5-RC2 [ 12316059 ]
        Resolution Fixed [ 1 ]
        Hide
        Peter Ertl added a comment -

        fixed

        Show
        Peter Ertl added a comment - fixed
        Attila Király made changes -
        Field Original Value New Value
        Attachment WICKET-3393-fix.patch [ 12469455 ]
        Hide
        Attila Király added a comment -

        Attaching suggested patch. Test pass with it.
        Patch contains a trivial change to the unrelated o.a.w.protocol.http.mock.MockServletContext class too. As wicket 1.5 needs servlet 2.5 the mock context should report minor version 5 instead of 3. I didn't want to open a different issue for this.

        Show
        Attila Király added a comment - Attaching suggested patch. Test pass with it. Patch contains a trivial change to the unrelated o.a.w.protocol.http.mock.MockServletContext class too. As wicket 1.5 needs servlet 2.5 the mock context should report minor version 5 instead of 3. I didn't want to open a different issue for this.
        Attila Király created issue -

          People

          • Assignee:
            Peter Ertl
            Reporter:
            Attila Király
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development