Wicket
  1. Wicket
  2. WICKET-3347

Simplify somehow the code in org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle)

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5-M3
    • Fix Version/s: 7.0.0
    • Component/s: wicket
    • Labels:
      None

      Description

      The code in org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle) decides whether to redirect or directly render the current page depending on several conditions:

      • is Ajax request
      • the redirect policy (org.apache.wicket.request.handler.RenderPageRequestHandler.RedirectPolicy)
      • the render strategy (org.apache.wicket.settings.IRequestCycleSettings.RenderStrategy)
      • whether the page is stateless

      All these conditions lead to complex and fragile code.

      We have to think how to improve this.

      1. fix-WICKET-3347.patch
        21 kB
        Michael Mosmann

        Issue Links

          Activity

            People

            • Assignee:
              Martin Grigorov
              Reporter:
              Martin Grigorov
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development