[WICKET-3347] Simplify somehow the code in org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle)

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5-M3
• Fix Version/s: 7.0.0-M1
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Martin Tzvetanov Grigorov
• Created: 18/Jan/11 10:29
• Updated: 13/Jun/13 09:49
• Resolved: 13/Jun/13 09:49

Description

The code in org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle) decides whether to redirect or directly render the current page depending on several conditions:

• is Ajax request
• the redirect policy (org.apache.wicket.request.handler.RenderPageRequestHandler.RedirectPolicy)
• the render strategy (org.apache.wicket.settings.IRequestCycleSettings.RenderStrategy)
• whether the page is stateless

All these conditions lead to complex and fragile code.

We have to think how to improve this.

Issue Links

• relates to: WICKET-3339 Url interception doesn't work if the "intercepting" page is stateless
• relates to: WICKET-4173 Incorrect URL for setResponsePage() within a Form#onSubmit( )