Wicket
  1. Wicket
  2. WICKET-3333

Links with multiple parameters are wrongly generated

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.5-RC1
    • Fix Version/s: 1.5-RC1
    • Component/s: wicket
    • Labels:
      None

      Description

      If you have a PageParameters, with multiple params, then the resulting link will be something like this /url?id=123&sid=456, so for some reason the & sign is encoded to & which will result in the following parameters on the receiving page:
      id=[123], amp;sid=[456]
      See the attached quickstart for example.

        Issue Links

          Activity

          Peter Major created issue -
          Hide
          Peter Major added a comment -

          Quickstart app demonstrating the problem.

          Show
          Peter Major added a comment - Quickstart app demonstrating the problem.
          Peter Major made changes -
          Field Original Value New Value
          Attachment wicket-3333.tar.gz [ 12468362 ]
          Martin Grigorov made changes -
          Assignee Martin Grigorov [ mgrigorov ]
          Martin Grigorov made changes -
          Link This issue is duplicated by WICKET-3334 [ WICKET-3334 ]
          Hide
          Martin Grigorov added a comment -

          With r1059051 this problem is fixed.
          But there are some more candidates for the same problem.

          Show
          Martin Grigorov added a comment - With r1059051 this problem is fixed. But there are some more candidates for the same problem.
          Martin Grigorov made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 1.5-RC2 [ 12316059 ]
          Resolution Fixed [ 1 ]
          Martin Grigorov committed 1059055 (1 file)
          Reviews: none

          WICKET-3333 Links with multiple parameters are wrongly generated
          WICKET-2829 Tag attributes values are not escaped properly during writeOutput

          Don't XML escape the link url. It is escaped in a central place (see WICKET-2829)

          Martin Grigorov committed 1059056 (1 file)
          Reviews: none

          WICKET-3333 Links with multiple parameters are wrongly generated
          WICKET-2829 Tag attributes values are not escaped properly during writeOutput

          Don't XML escape the link url. It is escaped in a central place (see WICKET-2829)

          Martin Grigorov committed 1059113 (1 file)
          Reviews: none

          WICKET-3333 Links with multiple parameters are wrongly generated
          WICKET-2829 Tag attributes values are not escaped properly during writeOutput

          By default do not escape the value of TextField. The value is already escaped by WICKET-2829.
          If the user wants to see the non-escaped value in the text field then she needs to explicitly call .setEscapeModelStrings(true).

          Martin Grigorov committed 1059125 (1 file)
          Reviews: none

          WICKET-3333 Links with multiple parameters are wrongly generated
          WICKET-2829 Tag attributes values are not escaped properly during writeOutput

          Don't XML escape the link url. It is escaped in a central place (see WICKET-2829)

          Martin Grigorov made changes -
          Fix Version/s 1.5-RC1 [ 12315483 ]
          Fix Version/s 1.5-RC2 [ 12316059 ]

            People

            • Assignee:
              Martin Grigorov
              Reporter:
              Peter Major
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development