[WICKET-3296] Url should accept null parameters list

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5-M3
• Fix Version/s: 1.5-RC1
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Willis Blackburn
• Created: 01/Jan/11 22:59
• Updated: 02/Jan/11 19:36
• Resolved: 02/Jan/11 19:36

Description

It's more natural to pass null than an empty list if there are no query parameters. It would be a simple change since Url just copies the parameters into its own list: if it's null then just don't copy.

public Url(List<String> segments, List<QueryParameter> parameters, Charset charset)

{ Args.notNull(segments, "segments"); // Remove: Args.notNull(parameters, "parameters"); this.segments.addAll(segments); if (parameters != null) this.parameters.addAll(parameters); setCharset(charset); }