[WICKET-3278] DropDownChoice no selection value

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5-M3
• Fix Version/s: 1.5-RC1
• Component/s: wicket
• Environment: Any
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Ivan Vasilev
• Created: 22/Dec/10 16:07
• Updated: 26/Dec/10 16:24
• Resolved: 26/Dec/10 16:24

Description

This problem came from this topic:
http://apache-wicket.1842946.n4.nabble.com/DropDownChoice-no-selection-value-td3160661.html

I've noticed that the method AbstractSingleSelectChoice.getNoSelectionValue() returns the value for no selection. In AbstractSingleSelectChoice.getDefaultChoice(final Object selected) on line 314:
return "\n<option selected=\"selected\" value=\"\">" + option + "</option>";

and on line 296:
buffer.append(" value=\"\">").append(option).append("</option>");

In those cases the null value option has empty value attribute. Wouldn't it be more consistent for this option to have the "value" attribute with the result provided from getNoSelectionValue()?