[WICKET-3217] DatesPage test LocaleDropDownChoice getObject calls getSelectedLocale(), does not use result

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.5-M3
• Component/s: wicket-datetime
• Environment: all
• Assignee: Peter Ertl
• Reporter: Richard Emberson
• Created: 02/Dec/10 17:10
• Updated: 02/Dec/10 21:41
• Resolved: 02/Dec/10 21:41

Description

In the DatesPage test, the LocaleDropDownChoice.getObject() method calls
getSelectedLocale() but does not use the result:

public List<Locale> getObject()
{
getSelectedLocale();
List<Locale> locales = new ArrayList<Locale>(LOCALES);
Collections.sort(locales, new Comparator<Locale>()
{
public int compare(Locale o1, Locale o2)

{ return o1.getDisplayName(selectedLocale).compareTo( o2.getDisplayName(selectedLocale)); }

});
return locales;
}

I would guess that the call getSelectedLocale() could be removed