Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-3217

DatesPage test LocaleDropDownChoice getObject calls getSelectedLocale(), does not use result

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.5-M3
    • Fix Version/s: None
    • Component/s: wicket-datetime
    • Labels:
      None
    • Environment:
      all

      Description

      In the DatesPage test, the LocaleDropDownChoice.getObject() method calls
      getSelectedLocale() but does not use the result:

      public List<Locale> getObject()
      {
      getSelectedLocale();
      List<Locale> locales = new ArrayList<Locale>(LOCALES);
      Collections.sort(locales, new Comparator<Locale>()
      {
      public int compare(Locale o1, Locale o2)

      { return o1.getDisplayName(selectedLocale).compareTo( o2.getDisplayName(selectedLocale)); }

      });
      return locales;
      }

      I would guess that the call getSelectedLocale() could be removed

        Attachments

          Activity

            People

            • Assignee:
              pete Peter Ertl
              Reporter:
              emberson Richard Emberson
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: