[WICKET-3033] Stack Overflow in getBeanDefinition()'s of SpringBeanLocator and AnnotProxyFieldValueFactory

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.10
• Fix Version/s: 1.4.12, 1.5-M2.1
• Component/s: wicket-spring
• Assignee: Igor Vaynberg
• Reporter: Maarten van Grootel
• Created: 06/Sep/10 13:56
• Updated: 17/Sep/10 14:48
• Resolved: 07/Sep/10 00:58

Description

The getBeanDefinition() in org.apache.wicket.spring.SpringBeanLocator and org.apache.wicket.spring.injection.annot.AnnotProxyFieldValueFactory will result in a Stack Overflow if a parent-context exists.

Offending code

private BeanDefinition getBeanDefinition(ConfigurableListableBeanFactory beanFactory,
			String name)
{
	[....]

	BeanFactory parent = beanFactory.getParentBeanFactory();
	if (parent != null && parent instanceof ConfigurableListableBeanFactory)
	{
		return getBeanDefinition(beanFactory, name);
	}

	[....]
}

As you can see it always calls the getBeanDefinition() with the same arguments resulting in a stack overflow. That specific return statement should call the getBeanDefinition of the parent and therefore should be:

	return getBeanDefinition((ConfigurableListableBeanFactory) parent, name);

I'll include a quick start to reproduce the error for the AnnotProxyFieldValueFactory and a patch to solve it for both.