[WICKET-3025] DateTextField converter does not honor current locale

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.10
• Fix Version/s: 1.4.11, 1.5-M2.1
• Component/s: wicket-extensions
• Assignee: Igor Vaynberg
• Reporter: Daniel Stoch
• Created: 30/Aug/10 09:03
• Updated: 17/Sep/10 14:48
• Resolved: 30/Aug/10 23:38

Description

I think there is a small bug in
org.apache.wicket.extensions.markup.html.form.DateTextField.
A DateConverter is created in the constructor:

converter = new DateConverter()
{
private static final long serialVersionUID = 1L;

/**

• @see org.apache.wicket.util.convert.converters.DateConverter#getDateFormat(java.util.Locale)
  */
  @Override
  public DateFormat getDateFormat(Locale locale) { return new SimpleDateFormat(DateTextField.this.datePattern); }

  };

But I think getDateFormat(...) method should looks like:

@Override
public DateFormat getDateFormat(Locale locale)
{
if (locale == null)

{ locale = Locale.getDefault(); }

return new SimpleDateFormat(DateTextField.this.datePattern. locale);
}