[WICKET-2996] if-modified-since checking is not working in AbstractResource

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5-M1
• Fix Version/s: 1.5-M2.1
• Component/s: wicket
• Assignee: Igor Vaynberg
• Reporter: Peter Ertl
• Created: 17/Aug/10 18:15
• Updated: 17/Sep/10 14:49
• Resolved: 17/Aug/10 18:37

Description

In AbstractResource the if-modified-since header is not working correctly

the servlet container seems not to deliver if-modified-since in milliseond precision

so a if-modified-since timestamp like 1281787899123 will be cut off to 1281787899000.

there was already a counter-measure in wicket-1.4 which seems to be missing in 1.5.

wicket-1.4:

WicketFilter, v 1.4.10, line 330ff:

if (ifModifiedSince < (lastModified / 1000 * 1000))

{ // If the servlet mod time is later, call doGet() // Round down to the nearest second for a proper compare // A ifModifiedSince of -1 will always be less maybeSetLastModified(httpServletResponse, lastModified); doGet(httpServletRequest, httpServletResponse); }

This kind of rounding ( / 1000 * 1000) is missing in 1.5 so the if-modified-since check eventually fails.

Patch is included.