[WICKET-2930] Method isSelected in Select should be public

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.9
• Fix Version/s: 1.5.1
• Component/s: wicket-extensions
• Assignee: Unassigned
• Reporter: Sven Ludwig
• Created: 01/Jul/10 11:29
• Updated: 17/Sep/11 23:38
• Resolved: 17/Sep/11 23:38

Description

Please change the scope of the method isSelected in the class org.apache.wicket.extensions.markup.html.form.select.Select to public so that it can be called from elsewhere or even overridden in subclasses elsewhere.

Background: In our current project we came to the conclusion that the Choice classes of the Wicket core are not suitable to implement panels with radio buttons, where the radio buttons need to be rendered from an EnumSet or from Collection. We particularly needed to be able to define the markup of each option in a template. Moreover we needed to be able to define the CSS classes on the option tag itself. Another requirement was Ajax support, in which the selection of a radio button is immediately submitted to the server. We had a look at the class org.apache.wicket.extensions.markup.html.form.select.Select which we knew was doing a good job for drop-down boxes in the way we needed it. We made the decision to create additional classes around it to support radio buttons. Our approach worked, but we had to use Java Reflection because the crucial method isSelected in the Select class is package local. Will there be changes in the Wicket core or in wicket-extensions to improve the support for radio buttons? I heard that in 1.5 there may be improvements.