Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-2912

IE 8 gets 404 error after continueToOriginalDestination() when app is at root context

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Not A Problem
    • Affects Version/s: 1.4.9
    • Fix Version/s: 1.4.13, 1.5-M3
    • Component/s: wicket
    • Labels:
    • Environment:
      Occurs on both Windows and Linux
      Running Tomcat 6
      JDK 1.6

      Description

      After recommendation we recently switched wicket app from /content to / (root) context. App was working fine before but after switching to root context calls to continueToOriginalDestination give 404 errors in IE but continues to work perfectly in FireFox and Opera.

      Patch to fix the problem:

      I have provided a fix to PageMap's continueToOriginalDestination that fixes the problem on IE and continues to work fine on FireFox and Opera for all the tests I could throw at it.

      This patch breaks some unit tests - probably tests that the redirect occurs on the exact interceptContinuationURL that was originally provided, naturally after stripping off the leading '/' these would no longer work.

      This fix may cause problems when the web app is NOT in the root context but I'm not sure - they may be fine with this.

      public final boolean continueToOriginalDestination()
      {
      // Get request cycle
      final RequestCycle cycle = RequestCycle.get();

      // If there's a place to go to
      if (interceptContinuationURL != null)

      { >> ADDED if ( interceptContinuationURL.length() > 0 && interceptContinuationURL.charAt(0) == '/' ) >> ADDED interceptContinuationURL = interceptContinuationURL.substring(1); cycle.setRequestTarget(new RedirectRequestTarget(interceptContinuationURL)); // Reset interception URL interceptContinuationURL = null; // Force session to replicate page maps dirty(); return true; }

      return false;
      }

        Attachments

        1. myproject.rar
          7 kB
          Igor Vaynberg

          Activity

            People

            • Assignee:
              ivaynberg Igor Vaynberg
              Reporter:
              golfman Chris Colman
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: