[WICKET-2767] DatePicker Calendar: wrong year format when 4 digits are used (yyyy), e.g. 2010 --> 0010

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.7
• Fix Version/s: 1.4.8, 1.5-M1
• Component/s: wicket-datetime
• Assignee: Igor Vaynberg
• Reporter: Giovanni
• Created: 07/Mar/10 14:36
• Updated: 13/May/10 13:17
• Resolved: 18/Mar/10 15:18

Description

I found that there is still a bug in Wicket 1.4.7 in case that the datePattern is "dd/MM/yyyy".

For example, if you use the DatePicker and select a date such as
23/02/2010 from the calendar GUI, the date selected in the DateTextField is "23/02/0010".

This is the example Java code:

// define the date text field for the data decorrenza
DateTextField dataDecorrenzaDaTextField = new DateTextField("dataDecorrenzaDa",
new PropertyModel(this.accordo, "dataDecorrenzaDa"),
new PatternDateConverter("dd/MM/yyyy", true)
);

// add the graphical calendar date picker
dataDecorrenzaDaTextField.add(new DatePicker() {

@Override
protected boolean enableMonthYearSelection()

{ // enable month/year selection return true; }

// end enableMonthYearSelection

} // end DatePicker

);

I found that the bug is still in the "wicket-date.js", line 137.

The wrong code is:

if(datePattern.match(/yy+/)) year = Wicket.DateTime.padDateFragment(year % 100);

This line also makes the module 100 on the year, when the year pattern is "yyyy".

The fixed code is:

if(datePattern.match(/yyyy+/)) {
year = year;
} else if(datePattern.match(/yy+/)) year = Wicket.DateTime.padDateFragment(year % 100);

Issue Links

• is duplicated by: WICKET-2648 DatePicker javascript uses 4 symbols for year although pattern contains just yy
• is duplicated by: WICKET-2805 DateTextField and DatePicker do not work properly with four digit year patterns in 1.4.7
• is duplicated by: WICKET-2841 DatePicker does not parse year with pattern dd.MM.yyyy correctly.