Wicket
  1. Wicket
  2. WICKET-2705

Feedback messages get cleaned up in AJAX request, thus never rendered and never visible to user

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.6
    • Fix Version/s: 6.0.0-beta1
    • Component/s: wicket
    • Labels:
      None
    • Environment:
      Sun Glassfish Enterpriser Server 2.1

      Description

      Consider a page containing a form and an AJAXy component (as in an AJAX link or a panel with AjaxSelfUpdatingTimerBehavior). The form contains code, that makes its processing take relatively long time, even when validation fails (let's say we forgot to fill in a requred field). The form gets submitted, and while it's processing, the AJAX component triggers a request (AJAX link gets clicked, or AjaxSelfUpdatingTimerBehavior kicks in). While the AJAX request gets served, cleanupFeedbackMessages() is called, wiping all feedback messages found by WebSession.MESSAGES_FOR_COMPONENTS filter.

      WebSession.MESSAGES_FOR_COMPONENTS implementation (or its usage in cleanupFeedbackMessages()) is a little bit fishy, as it accept()s messages, that haven't been rendered.

      Will add testcase.

      1. patch.txt
        3 kB
        Martijn Dashorst
      2. feedbackbug.patch
        0.5 kB
        Jan Winkler
      3. feedbackbug.tgz
        3 kB
        Jan Winkler

        Issue Links

          Activity

          Igor Vaynberg made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Igor Vaynberg made changes -
          Link This issue incorporates WICKET-499 [ WICKET-499 ]
          Igor Vaynberg made changes -
          Fix Version/s 1.6.0 [ 12315431 ]
          Fix Version/s 1.5-M3 [ 12315329 ]
          Igor Vaynberg made changes -
          Fix Version/s 1.5-M3 [ 12315329 ]
          Igor Vaynberg made changes -
          Assignee Igor Vaynberg [ ivaynberg ]
          Igor Vaynberg made changes -
          Link This issue is depended upon by WICKET-2948 [ WICKET-2948 ]
          Florian Wunderlich made changes -
          Link This issue relates to WICKET-2948 [ WICKET-2948 ]
          Martijn Dashorst made changes -
          Attachment patch.txt [ 12435311 ]
          Jan Winkler made changes -
          Affects Version/s 1.4.6 [ 12314470 ]
          Affects Version/s 1.3.7 [ 12313924 ]
          Jan Winkler made changes -
          Affects Version/s 1.3.7 [ 12313924 ]
          Affects Version/s 1.4.6 [ 12314470 ]
          Jan Winkler made changes -
          Comment [ Quick peek at wicket trunk shows that the same problem affects 1.4.

          See http://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/WebSession.java ]
          Jan Winkler made changes -
          Affects Version/s 1.4.6 [ 12314470 ]
          Affects Version/s 1.3.7 [ 12313924 ]
          Jan Winkler made changes -
          Attachment feedbackbug.patch [ 12431668 ]
          Jan Winkler made changes -
          Field Original Value New Value
          Attachment feedbackbug.tgz [ 12431665 ]
          Jan Winkler created issue -

            People

            • Assignee:
              Igor Vaynberg
              Reporter:
              Jan Winkler
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development