Wicket
  1. Wicket
  2. WICKET-266

maxPageVersions max int for HttpSessionStore is not good

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0 branch (discontinued), 1.2.5, 1.3.0-beta1
    • Fix Version/s: 1.3.0-beta1
    • Component/s: None
    • Labels:
      None

      Description

      In Settings:
      private int maxPageVersions = Integer.MAX_VALUE;

      That works ok for the second level cache session store, but is dangerous for HttpSessionStore. I think we should set the default to a better value, like 30 or less, and slcss should just ignore the whole setting

        Activity

        Hide
        Johan Compagner added a comment -

        but not used is depending on what every session store you make...
        But i guess the session store is the one that makes an undo manager. So that is the one that is in control.
        So i guess we can move that to the session store that creates it.

        Show
        Johan Compagner added a comment - but not used is depending on what every session store you make... But i guess the session store is the one that makes an undo manager. So that is the one that is in control. So i guess we can move that to the session store that creates it.
        Hide
        Eelco Hillenius added a comment -

        So if I understand correctly, the setting is not really used anymore. So can we remove it then?

        Show
        Eelco Hillenius added a comment - So if I understand correctly, the setting is not really used anymore. So can we remove it then?
        Hide
        Johan Compagner added a comment -

        we can set it ofcourse to a smaller value. But it is not dangerous with the AccesStackPageMap because that one keeps track of the page:versions combinations and only allows by default 7.

        Show
        Johan Compagner added a comment - we can set it ofcourse to a smaller value. But it is not dangerous with the AccesStackPageMap because that one keeps track of the page:versions combinations and only allows by default 7.

          People

          • Assignee:
            Unassigned
            Reporter:
            Eelco Hillenius
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development