Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-2635

Sucessfull login on SignInPanel causes HomePage to become stateful

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.5
    • 1.4.6, 1.5-M1
    • wicket-auth-roles
    • None

    Description

      Quickstart attached.

      Steps to reproduce
      1. Unpack attached quickstart
      2. mvn jetty:run
      3. Open http://localhost:8080/login
      4. Enter any credentials
      Expected: StatelessHomePage opens
      Actual: exception happends, StatelessHomePage isn't stateless

      Problem analysis:
      1. SignInForm manually creates page.
      2. AbstractListenerInterfaceRequestTarget.onProcessEvents calls requestCycle.setRedirect(true)
      3. RequestCycle.urlFor(final Component component, final RequestListenerInterface listener, ValueMap params) calls page.setPageStateless(Boolean.FALSE)
      4. StatelessChecker isn't happy.

      Fix is simple - SignInForm.onSignInSucceeded should be:
      if (!continueToOriginalDestination())
      {
      setResponsePage(getApplication().getHomePage());
      }

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jdonnerstag Juegen Donnerstag
            slonopotamus Marat Radchenko
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment