[WICKET-2635] Sucessfull login on SignInPanel causes HomePage to become stateful

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.5
• Fix Version/s: 1.4.6, 1.5-M1
• Component/s: wicket-auth-roles
• Assignee: Juegen Donnerstag
• Reporter: Marat Radchenko
• Created: 23/Dec/09 13:40
• Updated: 23/Dec/09 17:33
• Resolved: 23/Dec/09 17:33

Description

Quickstart attached.

Steps to reproduce
1. Unpack attached quickstart
2. mvn jetty:run
3. Open http://localhost:8080/login
4. Enter any credentials
Expected: StatelessHomePage opens
Actual: exception happends, StatelessHomePage isn't stateless

Problem analysis:
1. SignInForm manually creates page.
2. AbstractListenerInterfaceRequestTarget.onProcessEvents calls requestCycle.setRedirect(true)
3. RequestCycle.urlFor(final Component component, final RequestListenerInterface listener, ValueMap params) calls page.setPageStateless(Boolean.FALSE)
4. StatelessChecker isn't happy.

Fix is simple - SignInForm.onSignInSucceeded should be:
if (!continueToOriginalDestination())
{
setResponsePage(getApplication().getHomePage());
}