Wicket
  1. Wicket
  2. WICKET-2564

Modify wicket-devutils DebugBar so it emits valid XHTML

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.3
    • Fix Version/s: 1.4.4, 1.5-M1
    • Component/s: wicket
    • Labels:
      None

      Description

      It would be nice if the DebugBar would emit valid XHTML.

      In its current form, it emits img elements that lack the necessary alt attribute. This means that when you include a DebugBar on your page, it will cause XHTML validation of that page to fail.

      This is a minor issue, but the fix is also very simple: just add alt attributes to the DebugBar img elements.

      I will attach a patch.

        Activity

        Hide
        Jeremy Thomerson added a comment -

        Applied to trunk and 1.4.x

        Show
        Jeremy Thomerson added a comment - Applied to trunk and 1.4.x
        Hide
        Jeremy Thomerson added a comment -

        Thanks for the patch!

        Show
        Jeremy Thomerson added a comment - Thanks for the patch!
        Hide
        Matt Brictson added a comment -

        Patch against trunk @832323. Fixes XHTML issue and unit tests pass.

        Show
        Matt Brictson added a comment - Patch against trunk @832323. Fixes XHTML issue and unit tests pass.

          People

          • Assignee:
            Jeremy Thomerson
            Reporter:
            Matt Brictson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development