[WICKET-2469] Allow using a different FileItemFactory by extracting a method in MultipartServletWebRequest class

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.1
• Fix Version/s: 1.4.2, 1.5-M1
• Component/s: wicket
• Environment: Anyone
• Assignee: Igor Vaynberg
• Reporter: Esteban Masoero
• Created: 15/Sep/09 17:34
• Updated: 16/Sep/09 14:45
• Resolved: 16/Sep/09 06:40

Description

Hi there:

In MultipartServletWebRequest constructor we have:
...
(line 93) DiskFileItemFactory factory = new DiskFileItemFactory();
...
which inhibits anyone from reusing MultipartServletWebRequest with a different factory. The only solution is generate a new class that is a copy of this one, with that line changed.

The suggestion is to extract this code into a protected method, so we could just extend this class when there's a need to use a different factory (as in GAE applications).
A diff file is added.

Thanks in advance,

Esteban