[WICKET-2151] WicketSessionFilter doesn't takes into account WebApplication#getSessionAttributePrefix(WebRequest)

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.5
• Fix Version/s: 1.3.6, 1.4-RC3
• Component/s: wicket
• Environment: Any
• Assignee: Igor Vaynberg
• Reporter: Martin Grigorov (Inactive)
• Created: 07/Mar/09 17:30
• Updated: 26/Apr/09 18:34
• Resolved: 07/Mar/09 20:25

Description

WicketSessionFilter#init(FilterConfig), line 139 constructs the 'sessionKey' without taking into account the return value of WebApplication#getSessionAttributePrefix(WebRequest).

Patch:

Index: protocol/http/servlet/WicketSessionFilter.java
===================================================================
— protocol/http/servlet/WicketSessionFilter.java (revisión: 725053)
+++ protocol/http/servlet/WicketSessionFilter.java (copia de trabajo)
@@ -28,6 +28,7 @@
import javax.servlet.http.HttpSession;

import org.apache.wicket.Session;
+import org.apache.wicket.protocol.http.WebApplication;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

@@ -136,7 +137,8 @@
log.debug("filterName/ application key set to " + filterName);
}

• sessionKey = "wicket:" + filterName + ":" + Session.SESSION_ATTRIBUTE_NAME;
  + WebApplication application = WebApplication.get(filterName);
  + sessionKey = application.getSessionAttributePrefix(null) + Session.SESSION_ATTRIBUTE_NAME;

if (log.isDebugEnabled())
{

Issue Links

• relates to: WICKET-2180 WicketSessionFilter assumes that the WicketFilter has already been inited
• relates to: WICKET-2243 WicketSessionFilter assumes that the WicketFilter has already been inited