[WICKET-2139] RequestLogger change - include Page Parameters for BookmarkablePages

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.3.5, 1.4-RC2
• Fix Version/s: 1.4-RC3
• Component/s: wicket
• Assignee: Igor Vaynberg
• Reporter: Alex Deparvu
• Created: 03/Mar/09 09:14
• Updated: 07/Mar/09 07:56
• Resolved: 07/Mar/09 07:56

Description

From the dev-list: http://www.nabble.com/RequestLogger-change---include-Page-Parameters-for-BookmarkablePages-td22295982.html

Can you please add page parameters to the IRequestTarget logging ?

Its a simple addition to
org.apache.wicket.protocol.http.RequestLogger#getRequestTargetString(IRequestTarget
target) :

so this

else if (target instanceof IBookmarkablePageRequestTarget)

{ IBookmarkablePageRequestTarget pageRequestTarget = (IBookmarkablePageRequestTarget)target; sb.append("BookmarkablePage["); sb.append(pageRequestTarget.getPageClass().getName()); sb.append("]"); becomes }

else if (target instanceof IBookmarkablePageRequestTarget) {
IBookmarkablePageRequestTarget pageRequestTarget =
(IBookmarkablePageRequestTarget) target;
sb.append("BookmarkablePage[");
sb.append(pageRequestTarget.getPageClass().getName());
sb.append("(");
sb.append(pageRequestTarget.getPageParameters());
sb.append(")]");