[WICKET-2005] pb to access to this on event onchange on the AutoCompleteTextField

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4-RC1
• Fix Version/s: 1.4-RC3
• Component/s: wicket-extensions
• Environment: Windows XP, Firefox 3.0, IE7, safari 3.0
• Assignee: Igor Vaynberg
• Reporter: Olivier Dutrieux
• Created: 05/Jan/09 21:15
• Updated: 06/Feb/09 14:16
• Resolved: 01/Feb/09 22:01

Description

I would like create a component that extends AjaxEditableLabel with replace TextField with AjaxEditableAutoComplete.
And I discovert a problem in the wicket-autocomplete.js when the event onchange is rewriting (line 83) :

83// WICKET-1280
84 objonchangeoriginal=obj.onchange;
85 obj.onchange=function(event)

{ 86 if(mouseactive==1)return false; 87 if(typeof objonchangeoriginal=="function")objonchangeoriginal(); 88 }

89 objonchange=obj.onchange;

the problem is that the objonchangeoriginal function can't access to the this object, and it's necessary because I change the onchange event on AjaxEditableAutoComplete in case I extends AjaxEditableLabel with this :

editor.add(new EditorAjaxBehavior() {
private static final long serialVersionUID = 1L;
@Override
protected void onComponentTag(ComponentTag tag) {
super.onComponentTag(tag);
final String saveCall = "

{wicketAjaxGet('" + getCallbackUrl() + "&save=true&'+this.name+'='+wicketEncode(this.value)); return true;}

";
tag.put("onchange", saveCall);
}
});

then the best way to solve the problem is to change the invocation of objonchangeoriginal function with that :

83// WICKET-1280
84 objonchangeoriginal=obj.onchange;
85 obj.onchange=function(event)

{ 86 if(mouseactive==1)return false; 87 if(typeof objonchangeoriginal=="function")objonchangeoriginal.apply(this, [event]); 88 }

89 objonchange=obj.onchange;

all invocation of function need to be change this with new invocation on the wicket-autocomplete.js file

You find on attach file a simple example that's show the problem. And my version of wicket-autocomplete.js that solve the problem.

Duto