[WICKET-1980] Fixing JS error on autocomplete with preselect

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.4-RC2
• Component/s: wicket-extensions
• Environment: Firefox 3, Linux.; Wicket 1.3.4.
• Assignee: Juegen Donnerstag
• Reporter: Ivo Danihelka
• Created: 15/Dec/08 16:31
• Updated: 29/Dec/08 16:23
• Resolved: 29/Dec/08 16:23

Description

There is a Javascript error when using the autocomplete text field with preselect.
The error:
"element.firstChild is null"

The affected line is inside getSelectedValue():
var attr=element.firstChild.childNodes[selected].attributes['textvalue'];

How to reproduce:
1) Type something into the autocomplete text field. The javascript will send an Ajax request.
2) Hit enter quickly. When you hit it before the Ajax response arrives, the error occurs.

It is because the preselect sets selected=0, before sending the Ajax request.
It should be kept to -1 until the response arrives.

I'm going to attach a short patch for this.