Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.5, 1.4-RC1
    • Fix Version/s: 1.4.13, 1.5-M3
    • Component/s: wicket
    • Labels:
      None

      Description

      The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.

      1. ClientSideImageMape.patch
        19 kB
        Sven Meier
      2. WICKET-1936.patch
        17 kB
        James Carman

        Issue Links

          Activity

          Hide
          James Carman added a comment -

          Here's the implementation. I'll create test cases and attach a full patch later. I just wanted to get the discussion rolling on the implementation.

          Show
          James Carman added a comment - Here's the implementation. I'll create test cases and attach a full patch later. I just wanted to get the discussion rolling on the implementation.
          Hide
          James Carman added a comment -

          I need to fix that patch. The coordinates and type parameters to the Area class are reversed. Either the callers need to change how they're calling it or the parameters need to be switched.

          Show
          James Carman added a comment - I need to fix that patch. The coordinates and type parameters to the Area class are reversed. Either the callers need to change how they're calling it or the parameters need to be switched.
          Hide
          James Carman added a comment -

          Here's the implementation with test cases provided.

          Show
          James Carman added a comment - Here's the implementation with test cases provided.
          Hide
          Sven Meier added a comment -

          I'd like the current implementation to be revisited:
          Building markup in Java code makes this class look like part of a JSP tag library. The attached file does it "the wicket way".

          Show
          Sven Meier added a comment - I'd like the current implementation to be revisited: Building markup in Java code makes this class look like part of a JSP tag library. The attached file does it "the wicket way".
          Hide
          James Carman added a comment -

          Sven Meier, Are you saying you don't like the ClientSideImageMap implementation?

          Show
          James Carman added a comment - Sven Meier, Are you saying you don't like the ClientSideImageMap implementation?
          Hide
          Sven Meier added a comment -

          Implementation using a repeater (and Wicket formatting applied)

          Show
          Sven Meier added a comment - Implementation using a repeater (and Wicket formatting applied)
          Hide
          James Carman added a comment -

          That is more "wickety"! I like it. I've never understood RepeatingViews, so that's why I didn't use them I guess. This seems much cleaner. Although, I don't like that a behavior is named "Area". I'd probably rename it. A behavior does something (i.e. AttributeModifier, etc.) I'd name it something like AddAreaAttributes or something.

          Show
          James Carman added a comment - That is more "wickety"! I like it. I've never understood RepeatingViews, so that's why I didn't use them I guess. This seems much cleaner. Although, I don't like that a behavior is named "Area". I'd probably rename it. A behavior does something (i.e. AttributeModifier, etc.) I'd name it something like AddAreaAttributes or something.
          Hide
          Martin Grigorov added a comment -

          Reopen to revise the impl and port it to 1.4.x so the users can migrate to the new impl

          Show
          Martin Grigorov added a comment - Reopen to revise the impl and port it to 1.4.x so the users can migrate to the new impl
          Hide
          Martin Grigorov added a comment -

          The patch is applied and the new ImageMap implementation is ported to 1.4.x so the users can migrate to the new one before upgrade to 1.5.x

          Show
          Martin Grigorov added a comment - The patch is applied and the new ImageMap implementation is ported to 1.4.x so the users can migrate to the new one before upgrade to 1.5.x
          Hide
          Hudson added a comment -

          Integrated in Apache Wicket 1.5.x #357 (See https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/357/)

          Show
          Hudson added a comment - Integrated in Apache Wicket 1.5.x #357 (See https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/357/ )

            People

            • Assignee:
              Martin Grigorov
              Reporter:
              James Carman
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development