Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-1844

Wizard button implementations should not be final

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.4
    • Fix Version/s: 1.3.5, 1.4-RC1
    • Component/s: wicket-extensions
    • Labels:
      None

      Description

      I dont know why the wizard buttons are final but this makes it hard to add custom behaviour to them. For example, we need to hide a button if it's not enabled. We had to re-create all buttons by ourselves to do that instead of just overriding the isVisible() method of a button.
      Affects:
      org/apache/wicket/extensions/wizard/CancelButton
      org/apache/wicket/extensions/wizard/FinishButton
      org/apache/wicket/extensions/wizard/LastButton
      org/apache/wicket/extensions/wizard/NextButton
      org/apache/wicket/extensions/wizard/PreviousButton

      Suggestion: remove 'final' from class declaration

        Issue Links

          Activity

          Hide
          jcompagner Johan Compagner added a comment -

          i removed the finals from the class but there are still finals for some methods, but most of them are controlled by the WizardModel (like enabled)

          Show
          jcompagner Johan Compagner added a comment - i removed the finals from the class but there are still finals for some methods, but most of them are controlled by the WizardModel (like enabled)

            People

            • Assignee:
              jcompagner Johan Compagner
              Reporter:
              tapter Matthias Keller
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development