Wicket
  1. Wicket
  2. WICKET-1837

DiskPageStore: 32k directory entries.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4-M3
    • Fix Version/s: 1.4-RC5
    • Component/s: wicket
    • Labels:
      None
    • Environment:
      Caucho Resin 3.2

      Description

      When using JMeter to battletest a Wicket-App, i saw 31999 directories created (one per session) in the tmp dir to store the pagemaps.
      This is a problem because the underlying filesystem might (and does in my case) prevent wicket from creating more directory entries than that.

      i appended a very very simple patch to address this by creating
      <tmp>/ab/cd/ef instead of <tmp>/abcdef for pagemap storage.

        Issue Links

          Activity

          Hide
          Dominik Drzewiecki added a comment -

          Can anyone elaborate, why this patch hasn't been applied yet?

          Show
          Dominik Drzewiecki added a comment - Can anyone elaborate, why this patch hasn't been applied yet?
          Hide
          Bruno Borges added a comment -

          It's ok you didn't know.

          It's a new method added because of another issue.

          Show
          Bruno Borges added a comment - It's ok you didn't know. It's a new method added because of another issue.
          Hide
          uwe schaefer added a comment -

          ah. cool. i was not aware of this method.

          Show
          uwe schaefer added a comment - ah. cool. i was not aware of this method.
          Hide
          Bruno Borges added a comment - - edited

          I would add this change to this patch:

          @@ -385,6 +408,8 @@

          • sessionId = sessionId.replace('*', '_');
          • sessionId = sessionId.replace('/', '_');
            + sessionId = Files.cleanupFilename(String)

          Regards,
          Bruno

          Show
          Bruno Borges added a comment - - edited I would add this change to this patch: @@ -385,6 +408,8 @@ sessionId = sessionId.replace('*', '_'); sessionId = sessionId.replace('/', '_'); + sessionId = Files.cleanupFilename(String) Regards, Bruno
          Hide
          Igor Vaynberg added a comment -

          matej, where are we on this?

          Show
          Igor Vaynberg added a comment - matej, where are we on this?
          Hide
          Johan Compagner added a comment -

          matej, can we apply this patch?

          Show
          Johan Compagner added a comment - matej, can we apply this patch?
          Hide
          uwe schaefer added a comment -

          i added another simple patch according to your suggestions. this version should not leave garbage behind and create 3-levels of directories, which should be enough.

          Show
          uwe schaefer added a comment - i added another simple patch according to your suggestions. this version should not leave garbage behind and create 3-levels of directories, which should be enough.

            People

            • Assignee:
              Matej Knopp
              Reporter:
              uwe schaefer
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development