[WICKET-1825] url-escaping is not undone for requestcodingstrategy

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.6
• Assignee: Igor Vaynberg
• Reporter: Ann Baert
• Created: 09/Sep/08 14:59
• Updated: 02/Mar/10 09:06
• Resolved: 19/Jan/10 06:43

Description

When a resourceUrl with special characters is invoked by Wicket. Wicket does not read it correctly.

In the test-application I add two images.
The first one I call with a special character in the name of the resourceReference and it doesn't work (ERROR - shared resource org.apache.wicket.Application/withSpecialChar%DB%A9 not found).
The second one is the same image but with no special character in the call and that works fine.

Please also review WicketFilter, the method:getLastModified(final HttpServletRequest servletRequest). This need also be fixed.

I resolved the problem by changing the resourceReferenceKey in WicketFilter, getLastModified to:
final String resourceReferenceKey = WicketURLDecoder.PATH_INSTANCE.decode(pathInfo.substring(WebRequestCodingStrategy.RESOURCES_PATH_PREFIX.length()));
and I changed addResourceParameters(Request request, RequestParameters parameters) in WebRequestCodingStrategy:
StringBuffer path = new StringBuffer(WicketURLDecoder.PATH_INSTANCE.decode(pathInfo.substring(ix)));