Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-1810

StringRequestTarget is bloated and needs some care

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.3.5, 1.4-RC1
    • wicket
    • None

    Description

      when looking at StringRequestTarget I found the following things unnecessary

      (1) create a Charset object where a String is sufficient for the encoding
      (2) Write into a stream first, then read back from it and write to the response stream using an internal buffer
      (3) flush the output stream
      (4) having to specify the charset in the 'contentType' and again in the 'charset' parameter.

      I made up an own version of StringRequestTarget and attached a patch for it.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ehillenius Eelco Hillenius
            pete Peter Ertl
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment