Wicket
  1. Wicket
  2. WICKET-1799

wicket-extensions has unused reference to commons-collections.jar

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.5, 1.4-RC1
    • Component/s: wicket-extensions
    • Labels:
      None

      Description

      It seems that wicket-extensions (both 1.3 and 1.4) holds an unused reference to common-collections.jar in it's pom.xml.

      <dependency>
      <groupId>commons-collections</groupId>
      <artifactId>commons-collections</artifactId>
      </dependency>

      I removed that reference and could still compile everything without any error. Could someone double-check that and remove it if it's really not needed. this would save us from another 570 kb

      1. wicket-1799-wicket-1.4.patch
        0.4 kB
        Peter Ertl
      2. wicket-1799-wicket-1.3.patch
        0.5 kB
        Peter Ertl

        Activity

        Hide
        Peter Ertl added a comment -

        Patches included...

        Got a clean compile on 1.3.x and 1.4.x after removing commons-collections. I see no reason why this reference is needed so please remove it if you agree.

        Show
        Peter Ertl added a comment - Patches included... Got a clean compile on 1.3.x and 1.4.x after removing commons-collections. I see no reason why this reference is needed so please remove it if you agree.
        Hide
        Igor Vaynberg added a comment -

        seems like this was already removed from 1.4

        Show
        Igor Vaynberg added a comment - seems like this was already removed from 1.4
        Hide
        Peter Ertl added a comment - - edited

        for 1.3 the pom.xml is correct, however in 1.4.x the reference is still in there.

        Show
        Peter Ertl added a comment - - edited for 1.3 the pom.xml is correct, however in 1.4.x the reference is still in there.
        Hide
        Peter Ertl added a comment -

        thanks!

        Show
        Peter Ertl added a comment - thanks!

          People

          • Assignee:
            Igor Vaynberg
            Reporter:
            Peter Ertl
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development