Wicket
  1. Wicket
  2. WICKET-1795

Make it possible for to encode unicode strings in component

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.3.4
    • Fix Version/s: 1.3.5
    • Component/s: wicket
    • Labels:
      None

      Description

      It would be very nice to be able to tell a component for example label that it had to encode unicode chars into equalent html encoding, I've supplied a patch aswell.

      Additionally im not sure what goes for the wicket:message tag? It would be very nice to have a switch in markupsettings to decide all encoding.

        Activity

        Hide
        Nino Martinez added a comment -

        My attempt to solve this

        Show
        Nino Martinez added a comment - My attempt to solve this
        Hide
        Nino Martinez added a comment -

        Not major priority..

        Show
        Nino Martinez added a comment - Not major priority..
        Hide
        Martijn Dashorst added a comment -

        the non-ascii characters should not be in the markup file because they are encoded differently on different operating systems. The escape non-escaping markup test is therefore not possible to convert :S

        Show
        Martijn Dashorst added a comment - the non-ascii characters should not be in the markup file because they are encoded differently on different operating systems. The escape non-escaping markup test is therefore not possible to convert :S
        Hide
        Nino Martinez added a comment -

        hmm did'nt think of that.

        Show
        Nino Martinez added a comment - hmm did'nt think of that.
        Hide
        Nino Martinez added a comment -

        Argh, did'nt think of that.. :/

        Show
        Nino Martinez added a comment - Argh, did'nt think of that.. :/
        Hide
        Timo Rantalaiho added a comment -

        Martijn, surely you can have non-ASCII characters in the markup file as long as you ensure that the markup file will be read with the correct encoding (for example, by setting the "file.encoding" system property to "utf-8"). In many minor languages, such as Finnish, this makes a lot of sense – for example, "instructions of use" in Finnish would be "Käyttöohje" written with a common encoding that has more than just ASCII (such as UTF-8 or ISO-Latin-1 or ISO-Latin-9 or cp1252), but "Käyttöohje" in the escaped form. It's very handy to have the readable form everywhere, these character entity encodings are a thing of the past century to me

        Nino, can this issue be closed?

        Show
        Timo Rantalaiho added a comment - Martijn, surely you can have non-ASCII characters in the markup file as long as you ensure that the markup file will be read with the correct encoding (for example, by setting the "file.encoding" system property to "utf-8"). In many minor languages, such as Finnish, this makes a lot of sense – for example, "instructions of use" in Finnish would be "Käyttöohje" written with a common encoding that has more than just ASCII (such as UTF-8 or ISO-Latin-1 or ISO-Latin-9 or cp1252), but "Käyttöohje" in the escaped form. It's very handy to have the readable form everywhere, these character entity encodings are a thing of the past century to me Nino, can this issue be closed?
        Hide
        Johan Compagner added a comment -

        closing this one for now
        Why would you encode it by the way? Just serve it as UTF-8 which is the default in wicket anyway then you dont really need to encode it

        The whole world should listen to me for one time and switch over to UTF-8 now and drop all other charsets

        Show
        Johan Compagner added a comment - closing this one for now Why would you encode it by the way? Just serve it as UTF-8 which is the default in wicket anyway then you dont really need to encode it The whole world should listen to me for one time and switch over to UTF-8 now and drop all other charsets

          People

          • Assignee:
            Unassigned
            Reporter:
            Nino Martinez
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 20m
              20m
              Remaining:
              Remaining Estimate - 20m
              20m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development