[WICKET-1713] ModalWindow JavaScript does not restore tabIndexes correctly on IE 6

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.3, 1.4-M2
• Fix Version/s: 1.3.5, 1.4-M3
• Component/s: wicket-extensions
• Environment: IE 6, tested on Windows XP and CrossOver on Linux
• Assignee: Matej Knopp
• Reporter: Timo Heikki Rantalaiho
• Created: 25/Jun/08 03:59
• Updated: 27/Jun/08 23:41
• Resolved: 25/Jun/08 04:07

Description

Attached quickstart reproduces the problem before the fix. The problem is that if there are many input elements and some of them have tabindexes set, they are not restored properly when the modal window is closed.

It seems that when you do getElementsByTagName, IE 6 does not always return them in the same order.

I fixed this by using a custom javascript object property "hiddenTabIndex" to store the information directly to the manipulated element instead of the array. Object-oriented Javascript programming to save the world

It would be great if Matej and other javascript / ModalWindow experts could have a look!