Wicket
  1. Wicket
  2. WICKET-1713

ModalWindow JavaScript does not restore tabIndexes correctly on IE 6

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.3, 1.4-M2
    • Fix Version/s: 1.3.5, 1.4-M3
    • Component/s: wicket-extensions
    • Labels:
      None
    • Environment:
      IE 6, tested on Windows XP and CrossOver on Linux

      Description

      Attached quickstart reproduces the problem before the fix. The problem is that if there are many input elements and some of them have tabindexes set, they are not restored properly when the modal window is closed.

      It seems that when you do getElementsByTagName, IE 6 does not always return them in the same order.

      I fixed this by using a custom javascript object property "hiddenTabIndex" to store the information directly to the manipulated element instead of the array. Object-oriented Javascript programming to save the world

      It would be great if Matej and other javascript / ModalWindow experts could have a look!

        Activity

        Hide
        Timo Rantalaiho added a comment -

        To reproduce the problem, move from one text field to another with tab on IE, click "Show modal window", close the modal window, and try moving from one text field to another with tab again

        Show
        Timo Rantalaiho added a comment - To reproduce the problem, move from one text field to another with tab on IE, click "Show modal window", close the modal window, and try moving from one text field to another with tab again
        Hide
        Timo Rantalaiho added a comment -

        Interesting, I tried svn.eu.apache.org for the 1.3.x commit, but it seems like it does not come up in the Subversion commits tab. Maybe it's better not to use the EU mirror then.

        Show
        Timo Rantalaiho added a comment - Interesting, I tried svn.eu.apache.org for the 1.3.x commit, but it seems like it does not come up in the Subversion commits tab. Maybe it's better not to use the EU mirror then.
        Hide
        Timo Rantalaiho added a comment -

        Ah there it is, just with some delay.

        Show
        Timo Rantalaiho added a comment - Ah there it is, just with some delay.
        Hide
        Timo Rantalaiho added a comment -

        A quickstart reproducing a further problem that occurs when elements with stored tabindexes are updated via ajax

        Show
        Timo Rantalaiho added a comment - A quickstart reproducing a further problem that occurs when elements with stored tabindexes are updated via ajax
        Hide
        Timo Rantalaiho added a comment -

        Would be great if you could check if this makes sense

        Show
        Timo Rantalaiho added a comment - Would be great if you could check if this makes sense
        Hide
        Matej Knopp added a comment -

        Hi, sorry for late response. Looks good to me.

        Show
        Matej Knopp added a comment - Hi, sorry for late response. Looks good to me.

          People

          • Assignee:
            Matej Knopp
            Reporter:
            Timo Rantalaiho
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development