[WICKET-1704] ResourceStreamRequestTarget.configure set wrong ContentLength for non-ascii characters

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.5, 1.4-RC1
• Component/s: wicket
• Assignee: Igor Vaynberg
• Reporter: Jirka
• Created: 17/Jun/08 13:55
• Updated: 13/Jul/08 15:21
• Resolved: 13/Jul/08 15:21

Description

CharSequence export = DataBase.getInstance().exportDiscounts();
ResourceStreamRequestTarget target = new ResourceStreamRequestTarget(new StringResourceStream(export, "text/plain"));
target.setFileName("discounts.csv");
RequestCycle.get().setRequestTarget(target);

If export contains non-ascii characters. e.g. ěščřžýáíé, is wrong set up the ContentLength of the response. ContentLength is set up with number of characters, but must be set up with number of bytes. Response on output is not all.

Be sure that byte[].length != "čřžýá".length()

ResourceStreamRequestTarget.java method configure:

// WICKET-473 Allow IResourceStream.length() to return -1
long len = resourceStream.length();
if (len >= 0)

{ // and the content length response.setContentLength(len); }