Wicket
  1. Wicket
  2. WICKET-1704

ResourceStreamRequestTarget.configure set wrong ContentLength for non-ascii characters

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.5, 1.4-RC1
    • Component/s: wicket
    • Labels:
      None

      Description

      CharSequence export = DataBase.getInstance().exportDiscounts();
      ResourceStreamRequestTarget target = new ResourceStreamRequestTarget(new StringResourceStream(export, "text/plain"));
      target.setFileName("discounts.csv");
      RequestCycle.get().setRequestTarget(target);

      If export contains non-ascii characters. e.g. ěščřžýáíé, is wrong set up the ContentLength of the response. ContentLength is set up with number of characters, but must be set up with number of bytes. Response on output is not all.

      Be sure that byte[].length != "čřžýá".length()

      ResourceStreamRequestTarget.java method configure:

      // WICKET-473 Allow IResourceStream.length() to return -1
      long len = resourceStream.length();
      if (len >= 0)

      { // and the content length response.setContentLength(len); }

        Activity

        Igor Vaynberg made changes -
        Fix Version/s 1.3.5 [ 12313175 ]
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Martijn Dashorst made changes -
        Fix Version/s 1.4-M4 [ 12313295 ]
        Fix Version/s 1.3.4 [ 12313089 ]
        Fix Version/s 1.4-M3 [ 12312912 ]
        Jirka made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Igor Vaynberg made changes -
        Resolution Fixed [ 1 ]
        Status Reopened [ 4 ] Resolved [ 5 ]
        Jirka made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Igor Vaynberg made changes -
        Fix Version/s 1.3.4 [ 12313089 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 1.4-M3 [ 12312912 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Igor Vaynberg made changes -
        Field Original Value New Value
        Assignee Igor Vaynberg [ ivaynberg ]
        Jirka created issue -

          People

          • Assignee:
            Igor Vaynberg
            Reporter:
            Jirka
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development