[WICKET-1679] Memory leak in DiskPageStore

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.3
• Fix Version/s: 1.3.5
• Component/s: wicket
• Assignee: Matej Knopp
• Reporter: Stefan Fussenegger
• Created: 02/Jun/08 10:02
• Updated: 07/Jul/08 16:35
• Resolved: 07/Jul/08 16:32

Description

No entries are removed from DiskPageStore.sessionIdToEntryMap. I guess, this should be added to the DiskPageStore.unbind(String sessionId) method:

public void unbind(String sessionId)
{
// FIX: replace get() with remove()
SessionEntry entry = (SessionEntry)sessionIdToEntryMap.get(sessionId);
if (entry != null)
{
if (isSynchronous())

{ entry.unbind(); }

else
{
List pages = getPagesToSaveList(sessionId);
synchronized (pages)

{ flushPagesToSaveList(sessionId, pages); entry.unbind(); }

pagesToSaveAll.remove(sessionId);
}
}
}