Wicket
  1. Wicket
  2. WICKET-163

rating variable in RatingPanel should be of type IModel<Float> or IModel<Double> instead of IModel<Integer>

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Won't Fix
    • Affects Version/s: 2.0 branch (discontinued)
    • Fix Version/s: None
    • Component/s: wicket-extensions
    • Labels:
      None

      Description

      In the code of the RatingPanel (259) there is a comment line with the
      following text:
      // add the text label for the message 'Rating 4.5 out of 25 votes'
      with the following code
      ratingLabel = newRatingLabel(rater, "rating", rating, nrOfVotes);
      where the 'rating' variable should have the value '4.5' (see comment), but the type of this object is IModel<Integer>.
      I think this should be changed into IModel<Float> or IModel<Double>.

        Activity

          People

          • Assignee:
            Unassigned
            Reporter:
            Koen Molkenboer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development