[WICKET-1605] onclick is null or not an object in IE6, IE7; Form.appendDefaultButtonField

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.3.3, 1.4-M1
• Fix Version/s: 1.3.6, 1.4-RC2
• Component/s: wicket
• Environment: Windows XP Professional, glassfish, Internet Explorer 6 and Internet Explorer 7
• Assignee: Igor Vaynberg
• Reporter: Martin Müller
• Created: 09/May/08 13:09
• Updated: 01/Feb/09 22:25
• Resolved: 01/Feb/09 22:25

Description

JavaScript error when radio button has focus and return key is pressed:

IE6 and IE7 report a script error ("'onclick' is null or not an object"), which IMHO may be fixed in method

• protected void org.apache.wicket.markup.html.form.Form.appendDefaultButtonField(final MarkupStream markupStream, final ComponentTag openTag)

on line:

buffer.append("'); if (typeof(b.onclick) != 'undefined')

{ var r = b.onclick.bind(b)(); if (r != false) b.click(); } else { b.click(); }; return false;\" ");

It works for me replacing this line by:

buffer.append("'); if ((b.onclick != null) && (typeof(b.onclick) != 'undefined')) { var r = b.onclick.bind(b)(); if (r != false) b.click(); }

else

{ b.click(); }

; return false;\" ");