Wicket
  1. Wicket
  2. WICKET-1456

ImageMap blocks Image functionality

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.3.2
    • Fix Version/s: 1.5-M2.1
    • Component/s: wicket
    • Labels:
      None

      Description

      ImageMap is applied to an img tag, which means you can't apply an Image to that tag anymore. Since ImageMap does not supply the functionality of Image, this means it's impossible to treat an imagemap's image like a Wicket image (including dynamic rendering). And because ImageMap is final (why?), it's also not possible to extend it and add that functionality.

      I see three possible fixes:

      1: The easiest and ugliest fix: make ImageMap not final, and have the user figure it out.
      2: Add Image functionality to ImageMap. This duplicates functionality (since ImageMap can't inherit directly from Image), and might give problems in the future when new functionality is added to Image.
      3: Consider the current ImageMap broken, and replace it with a different approach: apply ImageMap to a <map> tag, use a regular image for the <img> part, and add to Image a method to link it to an ImageMap. I prefer the third solution, although it will break compatibility with existing ImageMaps. Perhaps a new DynamicImageMap could be added?

        Issue Links

          Activity

          Hide
          Martijn Vos added a comment -

          This patch is a quite thorough rewrite of ImageMap and a small addition to Image. ImageMap now links to a <map> tag, and Image allows an ImageMap to be linked to it (in order to set the usemap attribute).

          Show
          Martijn Vos added a comment - This patch is a quite thorough rewrite of ImageMap and a small addition to Image. ImageMap now links to a <map> tag, and Image allows an ImageMap to be linked to it (in order to set the usemap attribute).
          Hide
          James Carman added a comment - - edited

          You might want to check out my ClientSideImageMap implementation. I've linked the JIRA for it to this issue.

          Show
          James Carman added a comment - - edited You might want to check out my ClientSideImageMap implementation. I've linked the JIRA for it to this issue.
          Hide
          Igor Vaynberg added a comment -

          in 1.5 ImageMap is replaced by ClientSideImageMap that should cover this usecase

          Show
          Igor Vaynberg added a comment - in 1.5 ImageMap is replaced by ClientSideImageMap that should cover this usecase

            People

            • Assignee:
              Igor Vaynberg
              Reporter:
              Martijn Vos
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development