Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-1444

AbstractDecimalConverter has a numberFormats fields that holds NumberFormats, But those are not thread save...

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.2
    • Fix Version/s: 1.3.3
    • Component/s: wicket
    • Labels:
      None

      Description

      We really should remove that map because now they can be used multi threaded because for example the DoubleConverter has a static INSTANCE variable..

      The AbstractIntegerConverter doesnt do that caching for example, that returns a new Format instance everytime.

      The problem is that we can remove that map just fine, expects that we have setNumberFormat(Locale,Format) method
      thats is a method that is very wrong because ot the caching, And they should use/override getNumberFormat when you call setNumberFormat..

        Attachments

          Activity

            People

            • Assignee:
              jcompagner Johan Compagner
              Reporter:
              jcompagner Johan Compagner
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: