[WICKET-1419] GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from working correctly

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.3.1
• Fix Version/s: 1.3.2
• Assignee: Igor Vaynberg
• Reporter: Ryan Dearing
• Created: 13/Mar/08 00:02
• Updated: 13/Mar/08 00:27
• Resolved: 13/Mar/08 00:27

Description

the method findNext() in GridView.java has this code:

if (cells != null && cells.hasNext())
{
next = (Item)cells.next();
}

but it should be:

if (cells != null && cells.hasNext())
{
next = (Item)cells.next();
return;
}

I have attached a quickstart project that will recreate the bug. When you hit the "toggle buggy" link, the panel should maintain its state and you should see the text toggle from "false" to "true". As you can see, it works correctly in the 1st column of panels, but the second column does not work.

There is also a class called MyGridView in the attachment that fixes the issue.