[WICKET-1414] findSubmittingButton will fail when button without form is added before form

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.3.1
• Fix Version/s: 1.3.3
• Component/s: wicket
• Assignee: Johan Compagner
• Reporter: Petr Sakar
• Created: 11/Mar/08 22:34
• Updated: 24/Mar/08 11:21
• Resolved: 24/Mar/08 11:21

Description

Form submitting button is not found when page contains another button, which is not part of form and is added to the page hierarchy before form. When it is added after the form, it is working. The problem is in the method of Form class:

public final IFormSubmittingComponent findSubmittingButton()
{
IFormSubmittingComponent submittingComponent = (IFormSubmittingComponent) getPage().visitChildren(
IFormSubmittingComponent.class, new IVisitor()

which is serching for the submitting button in the whole page instead of the form only. I think correctly should be

public final IFormSubmittingComponent findSubmittingButton()
{
IFormSubmittingComponent submittingComponent = (IFormSubmittingComponent)visitChildren(
IFormSubmittingComponent.class, new IVisitor()