Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-1326

remove final from AjaxRequestTarget.addComponent(Component)

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.1
    • Fix Version/s: 1.3.2
    • Component/s: None
    • Labels:
      None

      Description

      Ajax behaviors are currently extremely hard to test because the final method AjaxRequestTarget.addComponent(Component) is final and can't be mocked.

      Does anyone object removing the final keyword?

        Activity

        Hide
        jcompagner Johan Compagner added a comment -

        not me

        Show
        jcompagner Johan Compagner added a comment - not me
        Hide
        thrantal Timo Rantalaiho added a comment -

        This would be excellent, as it would make unit testing ajax repaints much easier (often you need to test which components get added to AjaxRequestTarget).

        Show
        thrantal Timo Rantalaiho added a comment - This would be excellent, as it would make unit testing ajax repaints much easier (often you need to test which components get added to AjaxRequestTarget).
        Hide
        janne Janne Hietamäki added a comment -

        done

        Show
        janne Janne Hietamäki added a comment - done

          People

          • Assignee:
            janne Janne Hietamäki
            Reporter:
            janne Janne Hietamäki
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development