Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Invalid
    • Affects Version/s: 1.3.0-final, 1.3.1, 1.3.2
    • Fix Version/s: None
    • Component/s: wicket, wicket-extensions
    • Labels:
      None
    • Environment:
      All

      Description

      In org\apache\wicket\extensions\markup\html\repeater\data\table\NavigatorLabel.java:

      private NavigatorLabel(final String id, final PageableComponent table)
      {
      super(id);
      setModel(new StringResourceModel("NavigatorLabel", this, new Model(new LabelModelObject(
      table)), "Showing $

      {from}

      to $

      {to}

      of $

      {of}

      "));
      }

      The message "Showing x to y of z" is hardcoded, it should be extracted to a .properties file in order to allow for localization of the message.

        Activity

        Hide
        ivaynberg Igor Vaynberg added a comment -

        actually the hardcoded message is the fallback in case no .properties key was found. the first paremeter NavigatorLabel is the resource key that will be checked.

        Show
        ivaynberg Igor Vaynberg added a comment - actually the hardcoded message is the fallback in case no .properties key was found. the first paremeter NavigatorLabel is the resource key that will be checked.

          People

          • Assignee:
            ivaynberg Igor Vaynberg
            Reporter:
            dtoffe Daniel Toffetti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development