Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-1317

web.xml context-param is non-unique

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.0-final
    • Fix Version/s: 1.3.2
    • Component/s: wicket
    • Labels:
      None

      Description

      I note tha the current web.xml configuration to push wicket into dev mode is:

      <context-param>
      <param-name>configuration</param-name>
      <param-value>development</param-value>
      </context-param>

      Now shoot me down if you believe this to be a trivial objection, but I note that this wicket <param-name> string is very generic, and certainly cannot be guaranteed to be unique. It could easily collide with another component's "configuration" setting (though that would be an equally poorly named param-name).

      May I suggest this be changed to:

      <context-param>
      <param-name>wicket.configuration</param-name>
      <param-value>development</param-value>
      </context-param>

      I have tried to mark this issue "low key" as I don't want to ruffle feathers in my first wicket bug report

        Attachments

          Activity

            People

            • Assignee:
              ivaynberg Igor Vaynberg
              Reporter:
              dhpeterson David Peterson
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: