Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-1230

Temporary files not deleting when multipart upload fails with IO error

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 1.3.0-rc1
    • 1.3.0-final
    • wicket
    • None

    Description

      I just want to delete temporary files when upload fails (user cancelled or IO error occured), this is really important when uploading files about 500Mb, and this bug makes security hole (anyone can eating my server's disk space by posting incomplete large files).

      I can't find simple workaround, and I think that fix by developers will more easy.

      For example you can handle IO error in class org.apache.wicket.util.upload.FileUploadBase, method parseRequest, when IO error occured, just delete all created temporary files, and only after deleting files throw your FileUploadException.

      I hope you will fix it soon.
      Thanks.

      Attachments

        1. FileUploadBase.java.patch
          0.3 kB
          Yaroslav Malyshev
        2. FileUploadBase.java
          17 kB
          Yaroslav Malyshev

        Activity

          People

            jcompagner Johan Compagner
            yar Yaroslav Malyshev
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: