Wicket
  1. Wicket
  2. WICKET-1193

i18n: Translation of resource files in Korean

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.0-rc1
    • Fix Version/s: 1.3.1
    • Component/s: None
    • Labels:
      None

      Description

      I'd like to upload a patch for Korean resource files.

      1. korean-html-rcs.zip
        1.0 kB
        Woonsan Ko
      2. korean-rcs.zip
        21 kB
        Woonsan Ko

        Activity

        Hide
        Woonsan Ko added a comment - - edited

        Uploaded a patch containing Korean resource files.
        Thanks to all Wicket development team!

        The two gif files in the attached zip file should go into the following three destinations:

        (1) Beer_ko_KR.gif :
        a. ./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/pub/Beer_ko_KR.gif
        b. ./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/pub2/Beer_ko_KR.gif

        (2) flag_ko_KR.gif:
        a. ./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/flag_ko_KR.gif

        Show
        Woonsan Ko added a comment - - edited Uploaded a patch containing Korean resource files. Thanks to all Wicket development team! The two gif files in the attached zip file should go into the following three destinations: (1) Beer_ko_KR.gif : a. ./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/pub/Beer_ko_KR.gif b. ./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/pub2/Beer_ko_KR.gif (2) flag_ko_KR.gif: a. ./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/flag_ko_KR.gif
        Hide
        Frank Bille Jensen added a comment -

        Thank you, I will make sure it's applied before I release RC2

        Show
        Frank Bille Jensen added a comment - Thank you, I will make sure it's applied before I release RC2
        Hide
        Frank Bille Jensen added a comment -

        Applied the patch. Better late than never

        Can I get you to take a look at this html file, I think it doesn't look right, but I have no idea on how to fix it (or event if it's wrong):

        http://svn.apache.org/repos/asf/wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/pub/Home_ko_KR.html

        Show
        Frank Bille Jensen added a comment - Applied the patch. Better late than never Can I get you to take a look at this html file, I think it doesn't look right, but I have no idea on how to fix it (or event if it's wrong): http://svn.apache.org/repos/asf/wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/pub/Home_ko_KR.html
        Hide
        Woonsan Ko added a comment - - edited

        Thanks for applying the patch and pointing out my mistakes.
        Yeah, the Korean characters are broken in some html resource files.
        The safest way to contain unicode characters such as Korean or Chinese is to use numeric character references.
        I'm uploading an additional patch for fixing the problem. ( korean-html-rcs.zip )

        Show
        Woonsan Ko added a comment - - edited Thanks for applying the patch and pointing out my mistakes. Yeah, the Korean characters are broken in some html resource files. The safest way to contain unicode characters such as Korean or Chinese is to use numeric character references. I'm uploading an additional patch for fixing the problem. ( korean-html-rcs.zip )
        Hide
        Frank Bille Jensen added a comment -

        Forgot to commit the fixed html file

        Show
        Frank Bille Jensen added a comment - Forgot to commit the fixed html file
        Hide
        Frank Bille Jensen added a comment -

        Pushed. Thank you for the patch

        Show
        Frank Bille Jensen added a comment - Pushed. Thank you for the patch

          People

          • Assignee:
            Frank Bille Jensen
            Reporter:
            Woonsan Ko
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development