[WICKET-1172] FormComponentFeedbackIndicator and FormComponentFeedbackBorder is broken

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.3.0-rc1
• Fix Version/s: 1.3.0-rc2
• Component/s: wicket
• Assignee: Johan Compagner
• Reporter: Dmitry Rzhevskiy
• Created: 20/Nov/07 12:02
• Updated: 21/Nov/07 16:12
• Resolved: 21/Nov/07 16:12

Description

FormComponentFeedbackIndicator is not work. FormComponentFeedbackIndicator always invisible because:
first render forms contain no errors,
method FormComponentFeedbackIndicator.onBeforeRender (line 78) sets component invisible.
onBeforeRender() not call for invisible components.

workaround: override isVisible method :

@Override
public boolean isVisible()

{ return Session.get().getFeedbackMessages().hasMessage(this.getFeedbackMessageFilter()); }

method onBeforeRender don't need override in org.apache.wicket.markup.html.form.validation.FormComponentFeedbackIndicator

same situation with FormComponentFeedbackBorder .