Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-1166

add sanity check on form submit for request method

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.0-rc1
    • Fix Version/s: 1.3.2
    • Component/s: wicket
    • Labels:
      None
    • Environment:
      Safari 3

      Description

      When refreshing a frameset that includes an already POST submitted Wicket form in a frame, using the redirect to render strategy, Safari erroneously requests the form's original target by GET, rather than the location that was eventually redirected to. Therefore none of the form values are available in the request object and NPEs will occur trying to access them in places like AbstractConverter.java:55.

      Because Form allows for a particular request method to be specified, I think it should also confirm that the expected method was used instead of waiting for an NPE in validation. The outcome is the same, but the cause of the error (the client) would be more evident in server logs, etc. Patch to come...

        Attachments

        1. submit-method-javadoc.patch
          1 kB
          Nathan Hamblen
        2. submit-method.patch
          1 kB
          Nathan Hamblen

          Activity

            People

            • Assignee:
              ivaynberg Igor Vaynberg
              Reporter:
              n8han Nathan Hamblen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: