[WICKET-1160] AjaxEditableLabel#setModel() is broken

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0-rc2
• Component/s: wicket-extensions
• Assignee: Johan Compagner
• Reporter: Peter Ertl
• Created: 14/Nov/07 12:19
• Updated: 14/Nov/07 13:10
• Resolved: 14/Nov/07 13:10

Description

The following code

AjaxEditableLabel label = new AjaxEditableLabel("someid");
label.setModel(...);

will throw an NullPointerException.

The reason is...

public final Component setModel(IModel model)

{ super.setModel(model); *** getLabel().setModel(model); **** getEditor().setModel(model); return this; }

getLabel() returns null because the label is not initialized.

I suggest the following fix:

protected final Component getLabel()

{ return label; }

should be changed to

protected final Component getLabel()
{
if (label == null)

{ initLabelAndEditor(getParentModel()); }

return label;
}

this is similar to getEditor() which already initializes the component if it is null...