[WICKET-1117] FormComponent.setType is called in AbstractTextComponent.onBeforeRender

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0-beta4
• Fix Version/s: 1.3.0-rc1
• Component/s: wicket
• Environment: Linux
• Assignee: Johan Compagner
• Reporter: Bruno Borges
• Created: 31/Oct/07 13:53
• Updated: 03/Nov/07 13:01
• Resolved: 03/Nov/07 13:01

Description

The method FormComponent.setType() is called in onBeforeRender() and this will happen everytime, without having changes in the Model.
The only way I see to change the Model's Component, is calling setModel().
So, my suggestion is to override Component.setModel in AsbtractTextComponent calling super.setModel, and after that update the type.

public Component setModel(final IModel model)
{
Component component = super.setModel(model);
updateType();
return component;
}

protected void updateType()
{
if (getType() == null)
{
// Set the type, but only if it's not a String (see WICKET-606).
// Otherwise, getConvertEmptyInputStringToNull() won't work.
Class type = getModelType(getModel());
if (!String.class.equals(type))

{ setType(type); }

}
}